Skip to content
Permalink
Branch: master
Commits on Mar 21, 2019
  1. docs: fix html tags in changelog (#29411)

    macjohnny authored and matsko committed Mar 20, 2019
    PR Close #29411
Commits on Mar 20, 2019
  1. docs: add Luis Aviles to GDE resources (#29405)

    luixaviles authored and matsko committed Mar 19, 2019
    PR Close #29405
  2. build(bazel): add comment about advancing the version of yarn used un…

    gregmagolan authored and matsko committed Mar 20, 2019
    …der Bazel in the future (#29431)
    
    PR Close #29431
  3. build(bazel): revert back to yarn 1.12.1 under Bazel to fix Windows f…

    gregmagolan authored and matsko committed Mar 20, 2019
    …ile-in-use issues (#29431)
    
    PR Close #29431
  4. fix(ivy): emit generic type arguments in Pipe metadata (#29403)

    JoostK authored and matsko committed Mar 19, 2019
    Previously, only directives and services with generic type parameters
    would emit `any` as generic type when emitting Ivy metadata into .d.ts
    files. Pipes can also have generic type parameters but did not emit
    `any` for all type parameters, resulting in the omission of those
    parameters which causes compilation errors.
    
    This commit adds support for pipes with generic type arguments and emits
    `any` as generic type in the Ivy metadata.
    
    Fixes #29400
    
    PR Close #29403
  5. fix(ivy): ChangeDetectorRef should be injectable on ng-container (#29424

    marclaval authored and matsko committed Mar 20, 2019
    )
    
    PR Close #29424
  6. fix(ivy): Class selector directives execute properly on container ele…

    benlesh authored and matsko committed Mar 18, 2019
    …ments (#29383)
    
    PR Close #29383
  7. test: remove symlink workaround (#29426)

    alan-agius4 authored and matsko committed Mar 20, 2019
    This is no longer required. And is causing some errors to some of our engineers
    
    PR Close #29426
  8. feat(ivy): ngcc - support creating a new copy of the entry-point form…

    petebacondarwin authored and matsko committed Mar 20, 2019
    …at (#29092)
    
    This commit adds a `NewEntryPointFileWriter` that will be used in
    webpack integration. Instead of overwriting files in-place, this `FileWriter`
    will make a copy of the TS program files and write the transformed files
    there. It also updates the package.json with new properties that can be
    used to access the new entry-point format.
    
    FW-1121
    
    PR Close #29092
  9. refactor(ivy): ngcc - extract file writing out into a class (#29092)

    petebacondarwin authored and matsko committed Mar 20, 2019
    This is in preparation of having different file writing strategies.
    
    PR Close #29092
  10. refactor(ivy): ngcc - mark target entry-point as processed even if ng…

    petebacondarwin authored and matsko committed Mar 20, 2019
    …cc was a noop (#29092)
    
    If `targetEntryPointPath` is provided to `mainNgcc` then we will now mark all
    the `propertiesToConsider` for that entry-point if we determine that
    it does not contain code that was compiled by Angular (for instance it has
    no `...metadata.json` file).
    
    The commit also renames `__modified_by_ngcc__` to `__processed_by_ivy_ngcc__`, since
    there may be entry-points that are marked despite ngcc not actually compiling anything.
    
    PR Close #29092
  11. fix(ivy): ngcc - fail build-marker check if any formats were compiled…

    petebacondarwin authored and matsko committed Mar 20, 2019
    … with different ngcc (#29092)
    
    Now we check the build-marker version for all the formats
    rather than just the one we are going to compile.
    
    This way we don't get into the situation where one format was
    built with one version of ngcc and another format was built with
    another version.
    
    PR Close #29092
  12. refactor(ivy): ngcc - clean up the public API and export `hasBeenProc…

    petebacondarwin authored and matsko committed Mar 20, 2019
    …essed` helper (#29092)
    
    Now the public API does not contain internal types, such as `AbsoluteFsPath` and
    `EntryPointJsonProperty`. Instead we just accept strings and then guard them in
    `mainNgcc` as appropriate.
    
    A new public API function (`hasBeenProcessed`) has been exported to allow programmatic
    checking of the build marker when the package.json contents are already known.
    
    PR Close #29092
  13. refactor(ivy): ngcc - use a fixed set of properties to compile if non…

    petebacondarwin authored and matsko committed Mar 20, 2019
    …e provided (#29092)
    
    Previously we always considered all the properties in the package.json
    if no `propertiesToConsidere` were provided.
    But this results in computing a new set of properties for each entry-point
    plus iterating through many of the package.json properties that are
    not related to bundle-format paths.
    
    PR Close #29092
  14. fix(ivy): ngcc - teach Esm5ReflectionHost about aliased variables (#2…

    petebacondarwin authored and matsko committed Mar 20, 2019
    …9092)
    
    Sometimes, in ESM5 code, aliases to exported variables are used internally
    to refer to the exported value. This prevented some analysis from being
    able to match up a reference to an export to the actual export itself.
    
    For example in the following code:
    
    ```
    var HttpClientXsrfModule = /** @Class */ (function () {
      function HttpClientXsrfModule() {
      }
      HttpClientXsrfModule_1 = HttpClientXsrfModule;
      HttpClientXsrfModule.withOptions = function (options) {
          if (options === void 0) { options = {}; }
          return {
              ngModule: HttpClientXsrfModule_1,
              providers: [],
          };
      };
      var HttpClientXsrfModule_1;
      HttpClientXsrfModule = HttpClientXsrfModule_1 = tslib_1.__decorate([
          NgModule({
              providers: [],
          })
      ], HttpClientXsrfModule);
      return HttpClientXsrfModule;
    }());
    ```
    
    We were not able to tell that the `ngModule: HttpClientXsrfModule_1` property
    assignment was actually meant to refer to the `function HttpClientXrsfModule()`
    declaration.  This caused the `ModuleWithProviders` processing to fail.
    
    This commit ensures that we can compile typings files using the ESM5
    format, so we can now update the examples boilerplate tool so that it
    does not need to compile the ESM2015 format at all.
    
    PR Close #29092
  15. fix(ivy): ngcc - empower `Esm5ReflectionHost` to analyze `ModuleWithP…

    petebacondarwin authored and matsko committed Mar 20, 2019
    …roviders` functions (#29092)
    
    In ESM5 code, static methods appear as property assignments onto the constructor
    function. For example:
    
    ```
    var MyClass = (function() {
      function MyClass () {}
      MyClass.staticMethod = function() {};
      return MyClass;
    })();
    ```
    
    This commit teaches ngcc how to process these forms when searching
    for `ModuleWithProviders` functions that need to be updated in the typings
    files.
    
    PR Close #29092
  16. build(ivy): ngcc - only test under `no-ivy-aot` mode (#29092)

    petebacondarwin authored and matsko committed Mar 20, 2019
    We want ngcc to test non-AOT builds of the Angular packages,
    so we filter the tests in using the `no-ivy-aot` tag.
    
    PR Close #29092
  17. feat(ivy): ngcc - support only compiling the first format property to…

    petebacondarwin authored and matsko committed Mar 20, 2019
    … match (#29092)
    
    By default ngcc will compile all the format properties specified. With this
    change you can configure ngcc so that it will stop compiling an entry-point
    after the first property that matches the `propertiesToConsider`.
    
    PR Close #29092
  18. refactor(ivy): ngcc - simplify `Transformer.transform` API (#29092)

    petebacondarwin authored and matsko committed Mar 20, 2019
    By ensuring that EntryPointBundle contains everything that `Transformer.transform()`
    needs to do its work, we can simplify its signature.
    
    PR Close #29092
  19. refactor(ivy): ngcc - remove flat-format and use AbsoluteFsPath (#29092)

    petebacondarwin authored and matsko committed Mar 20, 2019
    Now that we are using package.json properties to indicate which
    entry-point format to compile, it turns out that we don't really
    need to distinguish between flat and non-flat formats, unless we
    are compiling `@angular/core`.
    
    PR Close #29092
  20. feat(ivy): ngcc - compile only specified package.json format properti…

    petebacondarwin authored and matsko committed Mar 20, 2019
    …es (#29092)
    
    You can now specify a list of properties in the package.json that
    should be considered (in order) to find the path to the format to compile.
    
    The build marker system has been updated to store the markers in
    the package.json rather than an additional external file.
    Also instead of tracking the underlying bundle format that was compiled,
    it now tracks the package.json property.
    
    BREAKING CHANGE:
    
    The `proertiesToConsider` option replaces the previous `formats` option,
    which specified the final bundle format, rather than the property in the
    package.json.
    If you were using this option to compile only specific bundle formats,
    you must now modify your usage to pass in the properties in the package.json
    that map to the format that you wish to compile.
    
    In the CLI, the `--formats` is no longer available. Instead use the
    `--properties` option.
    
    FW-1120
    
    PR Close #29092
  21. feat(ivy): ngcc - support targeting a start entry-point (#29092)

    petebacondarwin authored and matsko committed Mar 20, 2019
    You can now, programmatically, specify an entry-point where
    the ngcc compilation will occur.
    Only this entry-point and its dependencies will be compiled.
    
    FW-1119
    
    PR Close #29092
  22. refactor(ivy): expose ngcc programmatically (#29092)

    petebacondarwin authored and matsko committed Mar 20, 2019
    The `mainNgcc()` function has been refactored to make it easier to call
    ngcc from JavaScript, rather than via the command line.
    
    For example, the `yargs` argument parsing and the exception
    handling/logging have moved to the `main-ngcc.ts`
    file so that it is only used for the command line version.
    
    FW-1118
    
    PR Close #29092
  23. feat(ivy): ngcc - support dts compilation via ES5 bundles (#29092)

    petebacondarwin authored and matsko committed Mar 20, 2019
    Previously we only compiled the typings files, in ngcc, if there was
    an ES2015 formatted bundle avaiable. This turns out to be an artificial
    constraint and we can also support typings compilation via ES5 formats
    too.
    
    This commit changes the ngcc compiler to attempt typings compilation
    via ES5 if necessary. The order of the formats to consider is now:
    FESM2015, FESM5, ESM2015, ESM5.
    
    FW-1122
    
    PR Close #29092
  24. style(ivy): ngcc - fix typo in comment (#29092)

    petebacondarwin authored and matsko committed Mar 20, 2019
    PR Close #29092
  25. ci: add devversion to fw-dev-infra (#29418)

    gkalpak authored and matsko committed Mar 20, 2019
    PR Close #29418
  26. docs: add alexeagle to @angular/fw-global-approvers (#29287)

    alexeagle authored and matsko committed Mar 13, 2019
    This is for large-scale refactorings
    
    PR Close #29287
  27. feat(bazel): Upgrade rules_nodejs and rules_sass (#29388)

    kyliau authored and matsko committed Mar 18, 2019
    PR Close #29388
  28. docs: add docs team to Angular Team section on collaborators page (#2…

    brandonroberts authored and matsko committed Mar 19, 2019
    …9396)
    
    PR Close #29396
  29. test(ivy): update root cause of failures in MatBadge (#29422)

    marclaval authored and matsko committed Mar 20, 2019
    PR Close #29422
  30. test(ivy): remove passing snack bar test from blocklist (#29423)

    crisbeto authored and matsko committed Mar 20, 2019
    Removes the test that was fixed by angular/material2#15551 from the blocklist.
    
    PR Close #29423
  31. docs: fix typo (culd -> could) (#29412)

    meriturva authored and matsko committed Mar 20, 2019
    PR Close #29412
Older
You can’t perform that action at this time.