Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove remaining travis leftovers #27979

Closed

Conversation

Projects
None yet
6 participants
@devversion
Copy link
Member

commented Jan 8, 2019

  • There still seem to be a few TravisCI leftovers which can be removed now.
  • Also fixes that a few e2e tests aren't running. These have been disabled a long time ago, but can be re-enabled now.

@devversion devversion requested review from IgorMinar and angular/docs-infra as code owners Jan 8, 2019

@googlebot googlebot added the cla: yes label Jan 8, 2019

@mary-poppins

This comment has been minimized.

Copy link

commented Jan 8, 2019

@devversion devversion force-pushed the devversion:chore/remove-travis-leftovers branch from 4d73686 to f4d4e7b Jan 8, 2019

@mary-poppins

This comment has been minimized.

Copy link

commented Jan 8, 2019

devversion added some commits Jan 8, 2019

build: re-enable disabled e2e tests
Re-enables a few e2e tests which have been disabled a long time ago. Since these pass now, we should re-enable them.

@devversion devversion force-pushed the devversion:chore/remove-travis-leftovers branch from f4d4e7b to f335215 Jan 8, 2019

@ngbot ngbot bot added this to the needsTriage milestone Jan 8, 2019

@mary-poppins

This comment has been minimized.

Copy link

commented Jan 8, 2019

@gkalpak

gkalpak approved these changes Jan 8, 2019

@IgorMinar
Copy link
Member

left a comment

thanks!

@IgorMinar

This comment has been minimized.

@IgorMinar

This comment has been minimized.

Copy link
Member

commented Jan 9, 2019

caretaker note: pending review check is invalid because the PR has global approver approval

@ocombe this is a good example of when robot should not complain about pending reviews.

@ocombe

This comment has been minimized.

Copy link
Contributor

commented Jan 9, 2019

I removed the merge-assistance label as the bot is now able to ignore team review requests.

AndrewKushnir added a commit that referenced this pull request Jan 9, 2019

AndrewKushnir added a commit that referenced this pull request Jan 9, 2019

build: re-enable disabled e2e tests (#27979)
Re-enables a few e2e tests which have been disabled a long time ago. Since these pass now, we should re-enable them.

PR Close #27979

AndrewKushnir added a commit that referenced this pull request Jan 9, 2019

build: re-enable disabled e2e tests (#27979)
Re-enables a few e2e tests which have been disabled a long time ago. Since these pass now, we should re-enable them.

PR Close #27979

AndrewKushnir added a commit that referenced this pull request Jan 16, 2019

AndrewKushnir added a commit that referenced this pull request Jan 16, 2019

build: re-enable disabled e2e tests (#27979)
Re-enables a few e2e tests which have been disabled a long time ago. Since these pass now, we should re-enable them.

PR Close #27979

ngfelixl added a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019

ngfelixl added a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019

build: re-enable disabled e2e tests (angular#27979)
Re-enables a few e2e tests which have been disabled a long time ago. Since these pass now, we should re-enable them.

PR Close angular#27979
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.