Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove unused rollup.config.js files #28646

Conversation

Projects
None yet
4 participants
@devversion
Copy link
Member

commented Feb 11, 2019

Since we build and publish the individual packages using Bazel and
build.sh has been removed, we can safely remove the rollup.config.js
files which are no longer needed because the ng_package bazel rule
automatically handles the rollup settings and globals.

@devversion devversion requested a review from angular/fw-dev-infra as a code owner Feb 11, 2019

@ngbot ngbot bot added this to the needsTriage milestone Feb 11, 2019

@googlebot googlebot added the cla: yes label Feb 11, 2019

@alexeagle

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2019

Um, wait, I don't think any of the rollup.config.js files are used anymore, I think they were only referenced by build.sh. They ought to be deleted.

@devversion

This comment has been minimized.

Copy link
Member Author

commented Feb 13, 2019

Good point hmm. I will double-check that tomorrow.

@IgorMinar

This comment has been minimized.

Copy link
Member

commented Feb 13, 2019

@devversion please apply the merge label when you are ready - it seems that you want to check on the config before merging.

build: remove unused rollup.config.js files
Since we build and publish the individual packages
using Bazel and `build.sh` has been removed, we can
safely remove the `rollup.config.js` files which are no
longer needed because the `ng_package` bazel rule
automatically handles the rollup settings and globals.

@devversion devversion force-pushed the devversion:build/fix-rollup-config-tslint-rule-windows branch from 8b63223 to e590135 Feb 13, 2019

@devversion devversion requested review from IgorMinar and angular/fw-animations as code owners Feb 13, 2019

@devversion devversion requested a review from angular/tools-language-service as a code owner Feb 13, 2019

@devversion devversion changed the title build: fix rollup config tslint rule not working on windows build: remove unused rollup.config.js files Feb 13, 2019

@devversion

This comment has been minimized.

Copy link
Member Author

commented Feb 13, 2019

@IgorMinar @alexeagle I've updated this PR. We should be able to safely remove the rollup.config.js files.

can you please have another look? (I need a global approval/or review from all packages 😄)

@alexeagle alexeagle referenced this pull request Feb 13, 2019

Closed

Cleanup rollup #28716

mhevery added a commit that referenced this pull request Feb 14, 2019

build: remove unused rollup.config.js files (#28646)
Since we build and publish the individual packages
using Bazel and `build.sh` has been removed, we can
safely remove the `rollup.config.js` files which are no
longer needed because the `ng_package` bazel rule
automatically handles the rollup settings and globals.

PR Close #28646

@mhevery mhevery closed this in 7cbc36f Feb 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.