Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[Resolve #184] Add support for SNS stack notifications #220
Now able to specify a list of SNS topic ARNs within a stack config using the
I took a first stab at writing integration tests for this, but it raised a few questions:
Let me know what you think!
Before submitting the PR make sure the following are checked:
Thanks! We can leave out the integration tests and unit tests would suffice. Reasons being it would require checking the SNS topic that notification was published and the AWS account for integration tests has a topic setup. A lot of effort to check functionality which I feel will be adequately checked by unit tests.